Skip to content

fix: deprecated import of cacheddiscovery in vertical-pod-autoscaler #8829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2025
Merged

fix: deprecated import of cacheddiscovery in vertical-pod-autoscaler #8829

merged 1 commit into from
Nov 21, 2025
+2 −2

Conversation

@gsixo
Copy link
Contributor

@gsixo gsixo commented Nov 19, 2025

What type of PR is this?

/kind cleanup
/kind deprecation

What this PR does / why we need it:

Fixes deprecated imports of legacy NewMemCacheClient() from cacheddiscovery "k8s.io/client-go/discovery/cached" to cacheddiscovery "k8s.io/client-go/discovery/cached/memory"

Which issue(s) this PR fixes:

fixes NewMemCacheClient() import
in k8s.io/client-go/discovery/cached - NewMemCacheClient is DEPRECATED. Use memory.NewMemCacheClient directly.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [Usage]: https://pkg.go.dev/k8s.io/client-go/discovery/cached
- [Usage]: https://pkg.go.dev/k8s.io/client-go/discovery/cached/memory

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. labels Nov 19, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 19, 2025

Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 19, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 19, 2025

Hi @gsixo. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-area labels Nov 19, 2025
@adrianmoisey
Copy link
Member

adrianmoisey commented Nov 20, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 20, 2025
@adrianmoisey
Copy link
Member

adrianmoisey commented Nov 21, 2025

Thanks very much!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2025
omerap12
omerap12 approved these changes Nov 21, 2025
View reviewed changes
Copy link
Member

@omerap12 omerap12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gsixo, omerap12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2025
@adrianmoisey
Copy link
Member

adrianmoisey commented Nov 21, 2025

/release-note-none

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 21, 2025

@adrianmoisey: you can not set the release note label to "release-note-none" because the PR has the label "kind/deprecation".

In response to this:

/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adrianmoisey
Copy link
Member

adrianmoisey commented Nov 21, 2025

/remove-kind deprecation
/release-note-none

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 21, 2025

@adrianmoisey: you can not set the release note label to "release-note-none" because the PR has the label "kind/deprecation".

In response to this:

/remove-kind deprecation
/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot removed the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label Nov 21, 2025
@adrianmoisey
Copy link
Member

adrianmoisey commented Nov 21, 2025

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit 82018c9 into kubernetes:master Nov 21, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrianmoisey adrianmoisey Awaiting requested review from adrianmoisey

1 more reviewer

@omerap12 omerap12 omerap12 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adrianmoisey adrianmoisey

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gsixo @k8s-ci-robot @adrianmoisey @omerap12